Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gap is not supported across browsers, use padding instead #2334

Merged
merged 1 commit into from Nov 10, 2020

Conversation

karriebear
Copy link
Contributor

@karriebear karriebear commented Nov 10, 2020

Issue: Fixes #2330

Description: gap is not well supported across browsers. Let's just use padding


Contribution License Agreement

By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.

@karriebear karriebear requested a review from a team November 10, 2020 21:08
Copy link
Contributor

@akrolsmir akrolsmir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SAFARIIIII!!!

@karriebear karriebear merged commit 3a2b939 into streamlit:develop Nov 10, 2020
@akrolsmir
Copy link
Contributor

(Tested on PR Preview https://share.streamlit.io/streamlit/core-previews/pr-2334, with st_columns.py, on Safari)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Layouts] Padding does not work on safari
2 participants