Make blocks stale-able and fix emotion warning #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karriebear
force-pushed
the
expander-rerun
branch
from
3efadfa
to
d17be22
Compare
akrolsmir
approved these changes
Nov 10, 2020
There was a problem hiding this comment.
Looks great! Tested on PR Preview, by rerunning this snippet twice:
import streamlit as st
import time
time.sleep(3)
container = st.beta_container()
container.write("I cannot collapse")
expander = st.beta_expander("Collapse me!", expanded=True)
expander.write("I can collapse")
collapsed = st.beta_expander("Expand me!")
collapsed.write("I am already collapsed")
sidebar = st.sidebar.beta_expander("Expand me!")
sidebar.write("I am in the sidebar")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: Fixes #2291
Description: Previously only elements can be stale. The expander header is part of the block and is therefore not rendered with the element logic.
stale-elementto expander header if the block is staleContribution License Agreement
By submitting this pull request you agree that all contributions to this project are made under the Apache 2.0 license.