New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rethink TOML format for library #9

Closed

yuvadm opened this issue Oct 8, 2019 · 1 comment

Assignees

Labels

bug enhancement

Milestone

Member

yuvadm commented Oct 8, 2019 •

edited

Attempting to create a large-ish TOML file (~4MB) results in unreasonable parsing times (toml-rs/toml-rs#342)

Unless the cause of this issue is found and resolved, we might need to rethink the TOML design. Two possible ways to do that:

Use another deserialization format that can be parsed faster. This solution might have usability issues since TOMLs are pretty nice.
Compile the library (nightly? on demand on the user machine?) into some intermediate representation that can be efficiently parsed in runtime.

yuvadm added bug enhancement labels

yuvadm added this to the v1.0 milestone

yuvadm self-assigned this

Member Author

yuvadm commented Oct 26, 2019

This PR toml-rs/toml-rs#349 looks super promising, testing it on branch https://github.com/streamlib/streamlib/tree/toml-performance shows amazing results that are definitely acceptable

yuvadm closed this as completed in

a82c4ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment