Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: useCustomCompareEffect should import itself #909

Merged
merged 1 commit into from Jan 30, 2020
Merged

docs: useCustomCompareEffect should import itself #909

merged 1 commit into from Jan 30, 2020

Conversation

josmardias
Copy link
Contributor

@josmardias josmardias commented Jan 17, 2020 •
edited

Description

This PR makes useCustomCompareEffect example on docs properly import itself (instead of importing useDeepCompareEffect)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

@xobotyi xobotyi merged commit 2005535 into streamich:master Jan 30, 2020
@streamich
Copy link
Owner

🎉 This PR is included in version 13.22.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@josmardias josmardias deleted the patch-1 branch January 31, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xobotyi xobotyi xobotyi approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josmardias @streamich @xobotyi