Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: useSlider #680

Merged
merged 10 commits into from Jan 3, 2020
Merged

feat: useSlider #680

merged 10 commits into from Jan 3, 2020

Conversation

wardoost
Copy link
Contributor

Implementation of a slider hook taking a ref and options as parameters.

I would like some feedback on the hook signature of my proposal and also what options we would like to add. For example an option to clamp the return pos could be valuable?

Will add tests if we like the hook signature of this proposal.

Closes #42

@wardoost wardoost added the enhancement New feature or request label Oct 15, 2019
@wardoost wardoost changed the title useSlider feat: useSlider Oct 15, 2019
@streamich
Copy link
Owner

I love the demo :D

image

Copy link
Owner

@streamich streamich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/__stories__/useSlider.story.tsx Outdated Show resolved Hide resolved
src/useSlider.ts Outdated Show resolved Hide resolved
src/useSlider.ts Show resolved Hide resolved
@xobotyi xobotyi force-pushed the master branch 20 times, most recently from df57f5a to bd81db5 Compare November 3, 2019 04:09
@xobotyi xobotyi force-pushed the master branch 18 times, most recently from 4baf4c2 to 7e57723 Compare November 6, 2019 20:49
@streamich streamich merged commit 04acfe4 into master Jan 3, 2020
@streamich streamich deleted the useSlider branch January 3, 2020 18:57
@streamich
Copy link
Owner

🎉 This PR is included in version 13.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useSlider
2 participants