Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bunny video source changed to https #2515

Closed
wants to merge 4 commits into from
Closed

Bunny video source changed to https #2515

wants to merge 4 commits into from

Conversation

joeljtomy
Copy link

@joeljtomy joeljtomy commented Aug 11, 2023

Description

Change video source from http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4
to https://www.w3schools.com/tags/mov_bbb.mp4

serving via https

replacing links in

  • docs/useVideo.md
  • docs/useFullscreen.md
  • stories/useFullscreen.story.tsx
  • stories/useVideo.story.tsx

fixes #2513

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as before)
    ng change** (fix or feature that would cause existing functionality to not work as before)

Checklist

  • Read the Contributing Guide
  • Perform a code self-review
  • Comment the code, particularly in hard-to-understand areas
  • Add documentation
  • Add hook's story at Storybook
  • Cover changes with tests
  • Ensure the test suite passes (yarn test)
  • Provide 100% tests coverage
  • Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
  • Make sure types are fine (yarn lint:types).

Copy link

@ronnykind ronnykind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me

@joeljtomy joeljtomy closed this by deleting the head repository Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

useVideo.story.tsx - sampleVideo can not be loaded
2 participants