Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useFavicon is not dynamic #2486

Open
RachelScodes opened this issue Mar 10, 2023 · 0 comments
Open

useFavicon is not dynamic #2486

RachelScodes opened this issue Mar 10, 2023 · 0 comments

Comments

@RachelScodes
Copy link

RachelScodes commented Mar 10, 2023

What is the current behavior?
defining an app-level favicon, and a page level favicon, the override/fallback behavior doesn't work as expected. Sometimes when toggling, the favicon doesn't change at all. Sometimes it toggles but stays on that icon. It does not toggle/fallback the way I would expect

Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use.
Codesandbox link to see the code. But click to open in a new tab here to actually see the favicon change behavior)

What is the expected behavior?
I expect when viewing page 1 (with a favicon override) it always has this favicon:
bob_ross

I expect when viewing page 2 (no override favicon) it should fallback to the default favicon:
10_10

A little about versions:

  • OS:
  • Browser (vendor and version):
  • React:
  • react-use:
  • Did this worked in the previous package version?
@RachelScodes RachelScodes changed the title useFavicon ignores more specific overrides useFavicon is not dynamic Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant