You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
What is the current behavior?
defining an app-level favicon, and a page level favicon, the override/fallback behavior doesn't work as expected. Sometimes when toggling, the favicon doesn't change at all. Sometimes it toggles but stays on that icon. It does not toggle/fallback the way I would expect
Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than react-use. Codesandbox link to see the code. But click to open in a new tab here to actually see the favicon change behavior)
What is the expected behavior?
I expect when viewing page 1 (with a favicon override) it always has this favicon:
I expect when viewing page 2 (no override favicon) it should fallback to the default favicon:
A little about versions:
OS:
Browser (vendor and version):
React:
react-use:
Did this worked in the previous package version?
The text was updated successfully, but these errors were encountered:
RachelScodes
changed the title
useFavicon ignores more specific overrides
useFavicon is not dynamic
Mar 10, 2023
What is the current behavior?
defining an app-level favicon, and a page level favicon, the override/fallback behavior doesn't work as expected. Sometimes when toggling, the favicon doesn't change at all. Sometimes it toggles but stays on that icon. It does not toggle/fallback the way I would expect
Steps to reproduce it and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have extra dependencies other than
react-use
.Codesandbox link to see the code. But click to open in a new tab here to actually see the favicon change behavior)
What is the expected behavior?
I expect when viewing page 1 (with a favicon override) it always has this favicon:
I expect when viewing page 2 (no override favicon) it should fallback to the default favicon:
A little about versions:
react-use
:The text was updated successfully, but these errors were encountered: