Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mkdir return value #882

Merged
merged 3 commits into from Nov 19, 2022

Conversation

toyobayashi
Copy link
Contributor

@toyobayashi toyobayashi commented Nov 14, 2022

https://nodejs.org/dist/latest-v18.x/docs/api/fs.html#fsmkdirpath-options-callback

The callback is given a possible exception and, if recursive is true, the first directory path created, (err[, path]). path can still be undefined when recursive is true, if no directory was created.

https://nodejs.org/dist/latest-v18.x/docs/api/fs.html#fsmkdirsyncpath-options

Synchronously creates a directory. Returns undefined, or if recursive is true, the first directory path created.

Resolves #546

@toyobayashi
Copy link
Contributor Author

not sure why Jest runs timeout on macOS CI

@toyobayashi
Copy link
Contributor Author

Perhaps this PR can fix #546

src/volume.ts Outdated Show resolved Hide resolved
@G-Rath G-Rath merged commit 125ad2e into streamich:master Nov 19, 2022
streamich pushed a commit that referenced this pull request Nov 19, 2022
## [3.4.12](v3.4.11...v3.4.12) (2022-11-19)

### Bug Fixes

* `mkdir` return value ([#882](#882)) ([125ad2e](125ad2e))
@streamich
Copy link
Owner

🎉 This PR is included in version 3.4.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing mismatch between fs.mkdir and memfs.mkdir
3 participants