New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Android property key CStr
construction to add tests
#69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks.
I updated the CI to make sure the test is executed, because I don't think anyone of us will want to try every commit on our actual phones. :) |
63726f7
to
99893de
Compare
Add a new FFI utils module that is always tested on all platforms. Extract the C string bytes to a const and getter function, add more docs, add tests that the const can be safely turned into a `CStr`.
99893de
to
df6ac02
Compare
CStr
correctnessCStr
construction to add tests
I added |
Alright we have two approvals, I've addressed all of the comments, and the build is green. Since this has the |
Thanks for this! I went through the full history of PRs and issues and added these tags the best I could. |
Great, thanks @lopopolo . This is now ready to merge. Given its |
(@lopopolo somehow I missed your earlier message about merging on 7 October. Sorry about that!) |
Add a new FFI utils module that is always tested on all platforms.
Extract the C string bytes to a const and getter function, add more docs, add tests that the const can be safely turned into a
CStr
.