Fix: Fix it tries to use wasm_bindgen in wasm32-unknown-emscripten #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Can you write a CI test which this fixes? Also, what does "SSIA" mean? Don't worry about the existing CI test failures. They are unrelated. |
"Subject Says It All"
I don't think this is needed. We could only test that compiling for an emscripten target successfully fails at static link time instead of dynamic link time, i.e. during the build instead of only when you run it. I know too little about emscripten. I guess you can import native JavaScript methods somehow, and get our library working on this target, too. But I guess that's for another PR. |
Kijewski
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA.
closes #129.