Fail to launch server for fastapi == 0.89.0

[yuyupopo]

Using GraphQLRouter for fastapi version 0.89.0 fails.
This is due to tiangolo/fastapi#5857 .

Describe the Bug

In fastapi 0.89.0, it automatically parses response_class from the router function return type (tiangolo/fastapi#1436).
However, fastapi has a bug (tiangolo/fastapi#5857) which it cannot accept starlette.responses.* classes when it should.

Strawberry-graphql's

strawberry/strawberry/fastapi/router.py

Line 164 in db81482

) -> Response:

line defines starlette.responses.Response as return type. Therefore an error is raised.

Maybe remove the return type for now?

Upvote & Fund

• We're using Polar.sh so you can upvote and help fund this issue.
• We receive the funding once the issue is completed & confirmed by you.
• Thank you in advance for helping prioritize & fund our backlog.

[patrick91]

@yuyupopo this is a but in FastAPI, but we released a workaround, should be ok for now!

[tiangolo]

BTW, there was a fix and a release in FastAPI to have special handling when the type annotation is a Response, to avoid all the Pydantic validation, etc. So this should now work normally without problems. You probably already noticed, but as I just saw this issue linked from the original PR I wanted to come and comment that here. 🤓