Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current multi-threading work requires a version of Rust tokio crate higher than that currently available in rawhide #250

Closed
mulkieran opened this issue Dec 9, 2020 · 4 comments
Assignees
Projects

Comments

@mulkieran
Copy link
Member

See stratis-storage/stratisd#2337.

There's also an interesting note about tokio versions in dbus-rs here:
diwic/dbus-rs#289, indicating that new versions of dbus-rs may require a higher version of tokio.

We'll wait and see if Fedora rawhide version gets bumped regardless, otherwise we'll open negotiations about a new version in January.

@mulkieran mulkieran added this to To do in 2021January via automation Dec 9, 2020
@mulkieran
Copy link
Member Author

Current highest version is 0.2.22

@mulkieran
Copy link
Member Author

We can make the big jump to major version 1 if we want to.

@mulkieran
Copy link
Member Author

@jbaublitz Can you try moving your multi-threading PR to tokio major version 1? It will definitely require some code changes, because stream feature appears to have gone away. If that can be made to work, though, this issue can be closed.

@mulkieran
Copy link
Member Author

Closed, moved to tokio v1 succesfully.

2021January automation moved this from To do to Done Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

No branches or pull requests

2 participants