add injection zone screenshots #1543
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pwizla
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Thanks a lot, Cameron! It's lovely that you considered both color modes 😍
I have to request a few changes, though.
For consistency with other screenshots (see this one for instance) could you please use:
- a more Strapi-ish purple color instead of red:
RGB(128, 0, 127)/#80007F - Arial as a font for text annotations in screenshots
|
Thanks a lot again for opening this PR, @cpaczek. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
Fixes: #1542
Added 3 screenshots (technically 6) that show where the injection zones are.
Will use dark mode and light mode screenshots depending on docusarus theme.
/dev-docs/api/plugins/admin-panel-api#injection-zones-api