Skip to content

Styling bug fixes, story updates, and more QA #5650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Feb 19, 2019
Merged

Styling bug fixes, story updates, and more QA #5650

merged 19 commits into from
Feb 19, 2019

Conversation

domyen
Copy link
Member

@domyen domyen commented Feb 18, 2019

Issue: #5421

What I did

  • Fixed styling bugs in [v5] Styling bugs #5421.
  • Fixed console warnings due to styling
  • Update stories to be more realistic, remove blank stories

@domyen domyen added the cleanup Minor cleanup style change that won't show up in release changelog label Feb 18, 2019
@domyen domyen added this to the v5.0.0 milestone Feb 18, 2019
@domyen domyen requested a review from usulpro as a code owner February 18, 2019 16:55
@domyen domyen changed the title V5 style qa Styling bug fixes, story updates, and more QA Feb 18, 2019
@domyen domyen added the release label Feb 18, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. A couple of qns:

  1. Are you going to accept the changes in Chromatic?

  2. Are you sure all the nth-of-type changes are kosher? Kind of crappy to have to do that given SSR isn't even a thing.

@shilman shilman merged commit b766982 into next Feb 19, 2019
@shilman shilman deleted the v5-style-qa branch February 19, 2019 03:28
shilman added a commit that referenced this pull request Feb 19, 2019
Styling bug fixes, story updates, and more QA
@shilman shilman mentioned this pull request Feb 19, 2019
10 tasks
@domyen
Copy link
Member Author

domyen commented Feb 19, 2019

@tmeasday the nth-of-type stuff made no noticeable difference from a styling POV so I did them.

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants