-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Styling bug fixes, story updates, and more QA #5650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ndelangen can you review this proof of concept for SimpleBar scrollbars TODO: - Fix vertical scrollbar showing on Toolbar because items are loaded _after_ the SimpleBar runs (see https://github.com/Grsmto/simplebar#notifying-the-plugin-of-content-changes) - Add SimpleBar CSS to globalReset styles - Ensure SimpleBar CSS is accessible inside the SB iframe via .storybook/config.js
This reverts commit cf7f71c.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A couple of qns:
-
Are you going to accept the changes in Chromatic?
-
Are you sure all the
nth-of-type
changes are kosher? Kind of crappy to have to do that given SSR isn't even a thing.
Styling bug fixes, story updates, and more QA
@tmeasday the nth-of-type stuff made no noticeable difference from a styling POV so I did them. |
Issue: #5421
What I did