Fix issue with sb init on the Vue CLI
#4535
Conversation
This was removed in e496dfb Probably we should not even be using this preset (see #4475 (comment)), but we are, so I will add this for now to get it working.
tmeasday
requested review from
Hypnosphi,
ndelangen,
shilman and
stijnkoopal
as code owners
tmeasday
changed the title
sb init on the Vue CLI
| // installBabel below. For some reason it leads to the wrong version of @babel/core (a beta) | ||
| // being installed | ||
| if (packageBabelCoreVersion === '7.0.0-bridge.0') { | ||
| addToDevDependenciesIfNotPresent(packageJson, '@babel/core', babelCoreVersion); |
There was a problem hiding this comment.
So this leads to both babel-core and @babel/core being installed?
There was a problem hiding this comment.
Where the vue app uses babel-core and storybook uses @babel/core?
There was a problem hiding this comment.
Is this problematic? I don't know enough to understand the implications here.
There was a problem hiding this comment.
babel-core@7.0.0-bridge.0 is just a shim in front of @babel/core.
I don't really know why the Vue CLI installs it as it appears to use babel7.
There was a problem hiding this comment.
The issue (seems to my limited eyes) to be that babel-core@7.0.0-bridge.0 depends on @babel/core@7.0.0-0 (note the -0), which leads to this weird beta version of @babel/core being installed. This overrides that.
I feel like this is a mistake in the vue CLI 🤷♂️
Codecov Report
@@ Coverage Diff @@
## master #4535 +/- ##
==========================================
- Coverage 35.58% 35.57% -0.02%
==========================================
Files 557 557
Lines 6730 6732 +2
Branches 883 884 +1
==========================================
Hits 2395 2395
- Misses 3876 3877 +1
- Partials 459 460 +1
Continue to review full report at Codecov.
|
|
Confirmed fixed in rc.5 |
Issue: #4475
What I did
Re add
babel-preset-vueto vue init script.Also install a manual dep on
@babel/core, to fix yarn problems.How to test