Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alias decorateStory as applyDecorators for angular integration #19189

Merged
merged 1 commit into from Sep 16, 2022
Merged

Alias decorateStory as applyDecorators for angular integration #19189

merged 1 commit into from Sep 16, 2022

Conversation

spaceribs
Copy link
Contributor

Change Angular integration to export decorateStory as applyDecorators

Issue: #17330

What I did

Changed the decorateStory export to applyDecorators in the angular client config.ts

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@IanVS IanVS requested a review from tmeasday September 14, 2022 18:31
@tmeasday tmeasday added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 15, 2022
tmeasday
tmeasday approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@tmeasday tmeasday merged commit 7e91dfb into storybookjs:next Sep 16, 2022
@tmeasday
Copy link
Member

tmeasday commented Sep 16, 2022 •
edited

Verified this behaviour in the ComponentWrapperDecorator:With Component story in this PR:#19202 🎉 : https://www.chromatic.com/test?appId=6322ce6af69825592bbb28fc&id=63240048d7a461347f24a857

@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Sep 28, 2022
shilman pushed a commit that referenced this pull request Sep 28, 2022
@tmeasday @shilman
Merge pull request #19189 from spaceribs/fix/decorate-story-export
610073b 
Alias decorateStory as applyDecorators for angular integration
@dannyhw dannyhw mentioned this pull request Nov 26, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spaceribs @tmeasday @shilman @IanVS