Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React: Fix issue with react 18 implementation #19125

Merged
merged 4 commits into from Sep 8, 2022
Merged

React: Fix issue with react 18 implementation #19125

merged 4 commits into from Sep 8, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Sep 7, 2022

Follow up on #19118

Issue: When implementing a rendering story that checks a new button isn't created when setting an arg, I realised that I had actually broken things in #18737.

Now we have this story, we shouldn't be able to break things in this way again 馃

What I did

Changed the react callback behaviour

How to test

  1. Run rendering story
  2. Also check that the useEffect helper still works (there's a hooks.stories.ts story for this)
  3. The docs E2E should pick up if the callback isn't getting called properly.

shilman
shilman approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. Tests FTW!!!

code/renderers/react/src/render.tsx Outdated Show resolved Hide resolved
@shilman shilman self-assigned this Sep 7, 2022
@tmeasday tmeasday mentioned this pull request Sep 7, 2022
Merged
@shilman
Copy link
Member

shilman commented Sep 7, 2022

@tmeasday what's going on with CI here?

@tmeasday
Copy link
Member Author

tmeasday commented Sep 7, 2022

Oh, it needs to be updated with this commit: 1cb2f9d which is on the parent branches but hasn't made it in here yet.

Base automatically changed from tom/sb-586-remaining-core-features to next September 8, 2022 03:01
@shilman shilman changed the title Fix issue with react 18 implementation React: Fix issue with react 18 implementation Sep 8, 2022
@shilman shilman merged commit bae212c into next Sep 8, 2022
@shilman shilman deleted the react-18-followup branch September 8, 2022 09:02
@IanVS
Copy link
Member

IanVS commented Sep 13, 2022

Since #18737 was just released in 6.5.11, should this fix be patched back to 6.5 as well?

@tmeasday
Copy link
Member Author

Yes!

@tmeasday tmeasday added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Sep 13, 2022
shilman added a commit that referenced this pull request Sep 14, 2022
@shilman
Merge pull request #19125 from storybookjs/react-18-followup
6b2bd0a 
React: Fix issue with react 18 implementation
@jmaahir
Copy link

jmaahir commented Sep 20, 2022

Very good job 馃憤

@dannyhw dannyhw mentioned this pull request Nov 26, 2022
Merged
3 tasks
@yannbf yannbf mentioned this pull request Nov 30, 2022
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@shilman shilman

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tmeasday @shilman @IanVS @jmaahir