Addon-interactions: Fix IE support by replacing array includes #18993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
requested changes
Aug 22, 2022
There was a problem hiding this comment.
@JonathanKolnik we can probably still use optional chaining because that will get transpiled by babel. The includes => indexOf change should be sufficient, right?
|
I'm confused - storybook@7 will continue to support IE11, or is this a request for the current version? |
|
@dartess this got patched back to 6.5, so it's supposed to fix that. but actually @JonathanKolnik since this change is only for 6.5 this is kind of a special case and can you please target 7.0 will drop IE support |
JonathanKolnik
force-pushed
the
jonathankolnik/patch-ie-interactions-bug
branch
from
b293031
to
87a5534
Compare
|
Updated @shilman - sorry for the confusion! |
shilman
changed the title
shilman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored a piece of logic introduced in #18706 so that it is compatible to run in Internet Explorer.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.