Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Hook up the npm7 migration #18522

Merged
merged 1 commit into from Jun 21, 2022
Merged

CLI: Hook up the npm7 migration #18522

merged 1 commit into from Jun 21, 2022

Conversation

tmeasday
Copy link
Member

Issue: #18298

What I did

Actually hook it up

@tmeasday tmeasday requested a review from shilman June 21, 2022 04:02
@nx-cloud
Copy link

nx-cloud bot commented Jun 21, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e17e0f0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday added bug yarn / npm Yarn / npm acting weird patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 21, 2022
@shilman shilman changed the title Actually run the npm7 migration CLI: Hook up the npm7 migration Jun 21, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@shilman shilman merged commit 1edd3a6 into next Jun 21, 2022
@shilman shilman deleted the actually-use-npm7-migration branch June 21, 2022 07:02
shilman added a commit that referenced this pull request Jul 26, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch yarn / npm Yarn / npm acting weird
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants