UI: Fix sidebar a11y by moving aria-expanded attribute to button #18354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0e2988c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
changed the title
|
Any movement on this PR? Can we get tests passing? |
kylegach
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Thank you for this important fix, @Daraphista! And congratulations on a great first contribution! 🥳
The failing checks are unrelated to this work, so I'll merge it now.
kylegach
added
the
patch:yes
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Jul 26, 2022
UI: Fix sidebar a11y by moving aria-expanded attribute to button
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #18346
What I did
Moved the aria-expanded attribute from the RootNode to CollapseButton
How to test
You should see the changes reflected in the DOM