Ember: Remove global Ember usage

[dbendaou]

Issue:

What I did

Remove Ember global usage in favor of Component directly

How to test

• Is this testable with Jest or Chromatic screenshots?
• Does this need a new example in the kitchen sink apps?
• Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e2fda25. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 1 target

• nx run-many --target=prepare --all --parallel=2 --max-parallel=15 -- --optimized

---

Sent with 💌 from NxCloud.

[yannbf]

Hey @dbendaou thanks for this contribution! Is there a reason this PR is still a draft? Thanks!

[dbendaou]

Updated!

[dbendaou]

Could we move forward and have this merged? Since for now Storybook is unusable with Ember4 app

[yannbf]

@shilman could you release this? Thanks ♥️

[krezicoder]

Hi @shilman when can we expect this to be released ? Our entire dev workflow is blocked as we are not able to use storybook with ember 4.x

[shilman]

@dbendaou @yannbf @krezicoder This PR breaks CI -- specifically, it looks like there's a missing dependency on @ember/component:

[dbendaou]

Hey @shilman, I've updated my PR and updated the ember source dependencies to be able to leverage the module unification introduced in 3.27+ (previously it wasn't using "real" module)
It seems that TS cannot resolve the @ember/component dependencies, however, it's correctly implemented in ember-source here

And I'm able to properly run the Ember example

Also, ember-source doesn't provide type definition yet, they are working on it..

Do you know if I'm missing something ?

[gossi]

You may be able to pull in @types/ember__component to calm the CI for typechecks

[ndelangen]

How could this possibly work?
This @ember/component thing doesn't actually exist at all, on npm

[gossi]

@ember/component (amongst others) is a virtual package. ember-cli magic from the dark days makes it available during serving ember apps (it is virtual until this can be published on npm directly). Given this code is ~10yrs old, the virtual package is the required migration step.

What's needed to move this forward?

[ndelangen]

@gossi If you think this is good to merge, that's all that's required from me!

Please merge!, I think you have the access-level to do that, don't you?

[gossi]

Merging is blocked for me, @shilman requested changes. Can you unblock me or merge directly?

[ndelangen]

Merged!! Thank you @dbendaou and @gossi

[gossi]

@dbendaou we should backport this to storybook v6 - as it will take more time to make storybook v7 compatible with recent ember developments.

[SergeAstapov]

@shilman @dbendaou @gossi @ndelangen I'm open to help cherry-pick these changes to v6 but little confused which branch it should target. should it be next-release?

[shilman]

@SergeAstapov we’ll try to take care of it and will let you know if we need help cherry picking

[shilman]

This is now available in 6.5.15-alpha.0

[dbendaou]

We didn't had any issue and it's currently working ok in the alpha, do you think we could add it in the next 6.x release?

[SergeAstapov]

couple minor issues I've noticed with `peerDependencies:

    "@types/ember__component": "4.0.8",
    "ember-source": "~3.28.1"

this causes some issues... I believe these have to be changed to

    "@types/ember__component": "^4.0.8",
    "ember-source": "~3.28.1 || ^4.0.0"

[ndelangen]

@SergeAstapov Would you be open to opening a PR to remedy this? 🙏