Core: Fix error handling #8097
Merged
Core: Fix error handling #8097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
alexandrebodin,
alterx,
igor-dv,
shilman,
thomasbertet,
tmeasday and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-error-handling.storybook.now.sh |
Hypnosphi
commented
Sep 16, 2019
| showMain, | ||
| showError, | ||
| forceRender, | ||
| }: RenderMainArgs) { | ||
| const element = <StoryFn />; | ||
|
|
||
| if (!element) { |
There was a problem hiding this comment.
This condition is never true, as <StoryFn /> is never falsy
Hypnosphi
commented
Sep 16, 2019
| return; | ||
| } | ||
|
|
||
| if (!isReactRenderable(element)) { |
tmeasday
reviewed
Sep 17, 2019
| @@ -1,9 +1,7 @@ | |||
| import { document } from 'global'; | |||
| import React from 'react'; | |||
| import React, { ErrorInfo } from 'react'; | |||
There was a problem hiding this comment.
Is this used (ErrorInfo)? What version of react does it mean we require?
There was a problem hiding this comment.
not really, forgot to remove (and didn't get caught by eslint because of https://github.com/storybookjs/storybook/pull/6621/files#diff-e4403a877d80de653400d88d85e4801aR118, cc @ndelangen)
This was referenced Sep 17, 2019
shilman
added
the
patch:done
This was referenced Sep 26, 2019
Merged
[Snyk] Upgrade @storybook/addon-actions from 5.2.0 to 5.2.1
GrabarzUndPartner/gp-vue-boilerplate#234
Merged
Merged
Closed
Merged
This was referenced Oct 10, 2019
|
@dependabot ignore this major version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8087
What I did
– Added a try/catch
– Added an error boundary for React