Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix various storiesof-to-csf cases based on chromatic stories upgrade #9013

Merged
merged 2 commits into from Dec 2, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 30, 2019

Issue: N/A

What I did

See attached test cases & snapshots

@vercel
Copy link

vercel bot commented Nov 30, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should simplify the examples a bit? All the random Chromatic junk probably obscures what the test fixtures are trying to do.

@shilman shilman added this to the 5.3.0 milestone Dec 2, 2019
@shilman shilman merged commit 2e5a473 into next Dec 2, 2019
@shilman shilman deleted the storiesof-to-csf-improvements branch December 2, 2019 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants