Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: Add vscode launch.json for debugging #8993

Merged

Conversation

atanasster
Copy link
Member

Issue:
Out of the box ability to debug the launch/build process of official-storybook example

What I did

Updated .gitignore to allow checking in the launch.json file from VScode, no other VSCode files make sense to check-in for now.

How to test

In VSCode, set a breakpoint in one of the dist folders (ie @storybook/core) and start debugging session. In the debug console should say 'debugger attached'.

@vercel
Copy link

vercel bot commented Nov 28, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/d259nmy5x
🌍 Preview: https://monorepo-git-fork-atanasster-vscode-debug-official-storybook.storybook.now.sh

@atanasster atanasster changed the title added launch.json added vscode launch.json for debugging Nov 28, 2019
@shilman shilman changed the title added vscode launch.json for debugging Dev: Add vscode launch.json for debugging Nov 28, 2019
@shilman shilman added the maintenance User-facing maintenance tasks label Nov 28, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ❤️

@shilman shilman merged commit 8561e7b into storybookjs:next Nov 28, 2019
@shilman shilman deleted the vscode-debug-official-storybook branch November 28, 2019 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants