New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addon-A11y: Show errors, reset config properly #8779
Addon-A11y: Show errors, reset config properly #8779
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/o0ny2a1si |
@donaldpipowitch tests failing on something exactly relating to this PR:
|
Thanks for the heads up. I just noticed https://github.com/storybookjs/storybook/runs/297077854. |
Should be fixed now 👍 |
Cool, thanks. Gonna wait and see if @CodeByAlex or @jsomsanith-tlnd can review. But will review/merge if I don't hear back in a few days. |
Addon-A11y: Show errors, reset config properly
Issue: #8126
What I did
// ... axe options
comment in the README. It was ambiguous as it implied there were some "axe options" which could be spread into the configuration alongsideelement
/config
/options
.How to test
This change fixes this demo: https://github.com/donaldpipowitch/storybook-bug-demo-a11y-at-story-level
Questions
I needed to add
// eslint-disable-next-line react/destructuring-assignment
. If you don't like that change, I'd need to wrapA11YPanelState
in another object, because descruturing doesn't work well with tagged union types in that case. Any preference?Is there a way to run
$ yarn prepare
in a--watch
mode? That would help while debugging.Can I partially override a11y configs on a story level? The README implied it as far as I understood, but it isn't really written down literally. At least I always assumed it, but the code behaved like it would need the whole config even on a story level.