Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MDX: Handle <Story> name starting with number #8469

Merged
merged 2 commits into from Oct 18, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 18, 2019

Issue: #8467

What I did

Add underscore to exported var when story name starts with a number to fix JS parsing issues.

How to test

See updated test case

@shilman shilman requested a review from tmeasday October 18, 2019 03:24
@vercel
Copy link

vercel bot commented Oct 18, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/1lpaujn29
🌍 Preview: https://monorepo-git-8467-mdx-number-names.storybook.now.sh

@shilman shilman added bug mdx patch:yes Bugfix & documentation PR that need to be picked to main branch labels Oct 18, 2019
@shilman shilman added this to the 5.2.x milestone Oct 18, 2019
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nitpick

addons/docs/src/mdx/mdx-compiler-plugin.js Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug mdx patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants