Fix 'path is required in .pageview()' in GA addon

[soundasleep]

See #6012

This uses the fix in https://github.com/thundermiracle/storybook-loader/pull/19/files. Not tested - I don't have Typescript running locally.

[vercel]

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/ia5ysh0pb
🌍 Preview: https://monorepo-git-fork-soundasleep-patch-2.storybook.now.sh

[shilman]

Any chance you can test this? I have very little confidence that renamimg a variable would fix the problem, since it's not passed as a named argument.

[shilman]

Any chance you can test this? I have very little confidence that renamimg a variable would fix the problem, since it's not passed as a named argument.

[ndelangen]

@shilman WDYM?
It's invoking this API:
https://github.com/storybooks/storybook/blob/edb1896038f68db7d3f1e44faed021428d499fca/lib/api/src/modules/url.ts#L96-L103

that returns both a url and a path ?

[shilman]

@ndelangen so you think it's erroring because it's being passed a URL instead of a path. Can you test it? I'm not keen to merge a change that hasn't been tested.

[vesahyp]

Facing the same issue. As a temporary workaround i've added the same STORY_CHANGED event listener to another internal addon:

api.on(STORY_CHANGED, () => {
    const { path } = api.getUrlState();
    ReactGA.pageview(path);
});

Switching url to path works.

UPDATE: formatting

[shilman]

Thanks @vesahyp! Merging!