Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Add component meta to framework templates #8462

Merged
merged 1 commit into from Oct 17, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 17, 2019

Issue: #7543

What I did

Added export default { component: XXX } to all templates where there is a clear component used. Currently this is only useful for React and Vue, but eventually it will be used to auto generate prop tables for all frameworks.

How to test

cd lib/cli
yarn test

@vercel
Copy link

vercel bot commented Oct 17, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/bo6y4e08b
🌍 Preview: https://monorepo-git-7543-add-component-metadata.storybook.now.sh

@shilman shilman changed the title CLI: Add component meta to templates CLI: Add component meta to framework templates Oct 17, 2019
@shilman shilman added this to the 5.3.0 milestone Oct 17, 2019
Copy link
Contributor

@Aaron-Pool Aaron-Pool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 157cf12 into next Oct 17, 2019
@shilman shilman deleted the 7543-add-component-metadata branch October 17, 2019 17:41
@shilman shilman mentioned this pull request Oct 17, 2019
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants