Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect minimal required node version #8427

Merged
merged 1 commit into from Oct 17, 2019
Merged

Incorrect minimal required node version #8427

merged 1 commit into from Oct 17, 2019

Conversation

hcz
Copy link
Member

@hcz hcz commented Oct 15, 2019

Issue: minimal required node in the package.json is not correct

What I did

I've installed dependencies

 storybook $ node -v
v8.9.4

 storybook $ yarn bootstrap
yarn run v1.19.0
$ node ./scripts/bootstrap.js
? Select the bootstrap activities Core, Dll & Examples (core)
storybook info bootstrap Install dependencies (install)
[1/5] 馃攳  Validating package.json...
[2/5] 馃攳  Resolving packages...
[3/5] 馃殮  Fetching packages...
error @typescript-eslint/eslint-plugin@2.3.2: The engine "node" is incompatible with this module. Expected version "^8.10.0 || ^10.13.0 || >=11.10.1". Got "8.9.4"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How to test

  • Is this testable with Jest or Chromatic screenshots? No
  • Does this need a new example in the kitchen sink apps? No
  • Does this need an update to the documentation? Maybe, it seems no

If your answer is yes to any of these, please make sure to include it in your PR.

@vercel
Copy link

vercel bot commented Oct 15, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

馃攳 Inspect: https://zeit.co/storybook/monorepo/30ev3cqd5
馃實 Preview: https://monorepo-git-fork-hcz-bump-node.storybook.now.sh

@ndelangen ndelangen merged commit 552ea06 into storybookjs:next Oct 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants