New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update index.ts of jest addon to make withTests type generic #8410
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/9sx4eomxp |
@CodeByAlex how do I test this? |
The error that appears in the related issue is Making it |
Yeah, thats right @kroeder - I was thinking that there may be other use cases and didn't want to cause the same issues that we saw with making knobs strict. If you think it would be fine setting the type to StoryDecorator, I can change it to that. |
We could add tests for all possible inputs. That's the easiest way to ensure typings are correct I guess |
Addon-jest: Make withTests type generic
Issue: #8058
What I did
Update index.ts of jest addon to make withTests type generic
How to test
If your answer is yes to any of these, please make sure to include it in your PR.