New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabled error details webpack #8391
Enabled error details webpack #8391
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/e8znz0vti |
@dhuang612 thanks for putting this together! unfortunately, we're getting the following errors in CI. can you please take a look?
|
Hey, Yes I'll work on this over this next week. For next steps, I saw this comment saying:
Is this where I enable this setting? |
@shilman made changes to resolve errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! This LGTM. @ndelangen?
added configuration change to manager-webpack.config enabled display error details feature added in configuration change to stats
7a28fba
to
afb367f
Compare
awesome! |
@@ -53,6 +53,7 @@ export default function(options) { | |||
error.error = err; | |||
error.close = true; | |||
error.stats = stats; | |||
stats.toJson(options.errorDetails); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the only change?
Could you please explain what exactly this does?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's enabling the option errorDetails through the function toJson.
So if the managerConfig has an error it will provide information about the error
https://webpack.js.org/api/node/#statstojsonoptions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does stats.toJson
have side effects?
or does it mutate the given options.errorDetails
or does it mutate the stats
object itself?
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it mutates the given options.errorDetails
Issue:
enable verbose errors within webpack
What I did
added in the configuration to manager.webpack.configure
How to test
no additional tests should be needed