From e17e0f04a415a6cf8d06a4307d1873efff601559 Mon Sep 17 00:00:00 2001 From: Tom Coleman Date: Tue, 21 Jun 2022 13:31:48 +1000 Subject: [PATCH] Actually run the npm7 migration --- lib/cli/src/automigrate/fixes/index.ts | 2 ++ lib/cli/src/js-package-manager/NPMProxy.ts | 11 +++++++---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/lib/cli/src/automigrate/fixes/index.ts b/lib/cli/src/automigrate/fixes/index.ts index 566162243ed3..7cc92a1bba40 100644 --- a/lib/cli/src/automigrate/fixes/index.ts +++ b/lib/cli/src/automigrate/fixes/index.ts @@ -5,6 +5,7 @@ import { vue3 } from './vue3'; import { mainjsFramework } from './mainjsFramework'; import { eslintPlugin } from './eslint-plugin'; import { builderVite } from './builder-vite'; +import { npm7 } from './npm7'; import { Fix } from '../types'; export * from '../types'; @@ -16,4 +17,5 @@ export const fixes: Fix[] = [ mainjsFramework, eslintPlugin, builderVite, + npm7, ]; diff --git a/lib/cli/src/js-package-manager/NPMProxy.ts b/lib/cli/src/js-package-manager/NPMProxy.ts index a75d7d2b69fd..8f74cf57e446 100644 --- a/lib/cli/src/js-package-manager/NPMProxy.ts +++ b/lib/cli/src/js-package-manager/NPMProxy.ts @@ -23,10 +23,13 @@ export class NPMProxy extends JsPackageManager { } hasLegacyPeerDeps() { - return ( - this.executeCommand('npm', ['config', 'get', 'legacy-peer-deps', '--location=project']) === - 'true' - ); + const result = this.executeCommand('npm', [ + 'config', + 'get', + 'legacy-peer-deps', + '--location=project', + ]); + return result.trim() === 'true'; } setLegacyPeerDeps() {