Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min vue-loader dependency version #17912

Merged
merged 1 commit into from Apr 8, 2022
Merged

Bump min vue-loader dependency version #17912

merged 1 commit into from Apr 8, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Apr 7, 2022

Issue:

What I did

After #17834, it's possible that the vue project will use webpack 5, but versions of vue-loader earlier than https://github.com/vuejs/vue-loader/releases/tag/v16.4.1 will fail, as seen in storybookjs/builder-vite#320 (comment).

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

I checked this by setting resolutions in my yarn.lock to force vue-loader 16.4.1, and my error was resolved.

@nx-cloud
Copy link

nx-cloud bot commented Apr 7, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d8b78ed. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IanVS LGTM but isn't this a breaking change?

@ndelangen any thoughts here? i know you prefer to keep the version ranges as wide as possible

@shilman shilman added the vue label Apr 7, 2022
@IanVS
Copy link
Member Author

IanVS commented Apr 7, 2022

but isn't this a breaking change?

I don't think so. It should just install a new minor version using normal dependency hoisting rules by the various package managers. If it's not compatible with a version a user has installed, it'll go into a nested node_modules, usually.

Can you explain why you think this might be breaking?

@IanVS
Copy link
Member Author

IanVS commented Apr 7, 2022

Note, this is a dependency and not a peerDependency, if that's what you were thinking.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM!

@shilman shilman merged commit c3c10a6 into next Apr 8, 2022
@shilman shilman deleted the vue-loader-min branch April 8, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants