Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix user-supplied project-level render in v6 store #17885

Merged
merged 2 commits into from Apr 7, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Apr 5, 2022

What I did

Ensure a user-supplied render function (from project annotations) overrides the framework one.

How to test

  • Is this testable with Jest or Chromatic screenshots?

@nx-cloud
Copy link

nx-cloud bot commented Apr 5, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 23d3ae0. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@tmeasday tmeasday requested a review from shilman April 5, 2022 07:27
@tmeasday tmeasday added the bug label Apr 5, 2022
@shilman shilman changed the title Ensure you can set render in v6 store Core: Fix user-supplied project-level render in v6 store Apr 7, 2022
@shilman shilman added the core label Apr 7, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman merged commit c313cf8 into next Apr 7, 2022
@shilman shilman deleted the tom/sb-233-cannot-override-render-function-in-v6 branch April 7, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants