Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Preserve quote style in automigrate #17858

Merged
merged 1 commit into from Apr 2, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Apr 2, 2022

Issue: N/A

What I did

  • Use babel generator instead of JSON.stringify so keys are not wrapped in quotes
  • Infer single vs. double quotes based on number of occurrences

Self-merging @yannbf

How to test

See attached tests

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 2, 2022
@nx-cloud
Copy link

nx-cloud bot commented Apr 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 50368e1. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit de76197 into next Apr 2, 2022
@shilman shilman deleted the tech/automigrate-preserve-quotes branch April 2, 2022 23:48
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 9, 2022
shilman added a commit that referenced this pull request Apr 9, 2022
…quotes

CLI: Preserve quote style in automigrate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant