Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI: Add automigration to @storybook/builder-vite #17829

Merged
merged 2 commits into from Mar 31, 2022
Merged

CLI: Add automigration to @storybook/builder-vite #17829

merged 2 commits into from Mar 31, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 30, 2022 •
edited

Issue: N/A

What I did

  • Add automigration from storybook-builder-vite to @storybook/builder-vite & tests
  • Add manual instructions to MIGRATION.md

How to test

See attached tests. Also:

yarn build cli
cd /path/to/existing-vite-project
/path/to/storybook/lib/cli/bin/index.js automigrate

@nx-cloud
Copy link

nx-cloud bot commented Mar 30, 2022 •
edited

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 6d847d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman requested a review from IanVS March 30, 2022 17:03
joshwooding
joshwooding approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit 55ae2c3 into next Mar 31, 2022
@shilman shilman deleted the feat/add-vite-builder-automigration branch March 31, 2022 04:57
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 1, 2022
shilman added a commit that referenced this pull request Apr 1, 2022
@shilman
Merge pull request #17829 from storybookjs/feat/add-vite-builder-auto…
a1dc9a0 
…migration

CLI: Add automigration to `@storybook/builder-vite`
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@IanVS IanVS Awaiting requested review from IanVS

Assignees
No one assigned
Labels
builder-vite cli feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @joshwooding