Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls: Fix date control width in addons panel #17780

Merged
merged 1 commit into from Apr 4, 2022

Conversation

fbredius
Copy link
Contributor

Issue: #17225

What I did

I changed the width ratio between the date-input and time-input in the addons panel. Instead of an even division of 1 to 1, I changed it to 4 to 3 using flex-grow, since the date in the date-input needs more space. This solves the issue where the date in the date-input was not fully visible, as can be seen in #17225.

See the screenshots for how it looks now, in the issue ticket there is a screenshot on how it looked before.

With the addons panel on the right of the page:
image

With the addons panel on the bottom of the page:
image

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Mar 22, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 83f57c7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@fbredius fbredius changed the title #17225 Fix date control width in addons panel #17225 [Bugfix] Fix date control width in addons panel Mar 22, 2022
@shilman shilman changed the title #17225 [Bugfix] Fix date control width in addons panel Controls: Fix date control width in addons panel Mar 28, 2022
Copy link
Collaborator

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, @fbredius! Thanks!

@kylegach kylegach added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 4, 2022
@kylegach kylegach merged commit d377613 into storybookjs:next Apr 4, 2022
@shilman shilman added the bug label Apr 5, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 9, 2022
shilman pushed a commit that referenced this pull request Apr 9, 2022
Controls: Fix date control width in addons panel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: controls bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants