Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix core.builder check #17606

Merged
merged 1 commit into from Mar 7, 2022
Merged

Core: Fix core.builder check #17606

merged 1 commit into from Mar 7, 2022

Conversation

yanick
Copy link
Contributor

@yanick yanick commented Mar 2, 2022

...because it took me way too long to figure out that my Storybook was b0rked because I had tried storybook-builder-vite in the past and my main.js had

core: {
  // builder: 'storybook-builder-vite'
}

It doesn't help that the error message was overly mysterious too.

...because it took me way too long to figure out that my Storybook was b0rked because I had tried `storybook-builder-vite` in the past and my main.js had

```
core: {
  // builder: 'storybook-builder-vite'
}
```

It doesn't help that the error message was overly mysterious too.
@nx-cloud
Copy link

nx-cloud bot commented Mar 2, 2022

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 19e49d8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title check for presence of core.builder Core: Fix core.builder check Mar 7, 2022
@shilman shilman added bug core patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 7, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks so much for the fix @yanick !

@shilman shilman merged commit 40d2e9c into storybookjs:next Mar 7, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 1, 2022
shilman added a commit that referenced this pull request Apr 1, 2022
Core: Fix core.builder check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants