Core: Ensure we show an error when configure() throws
#17435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI ran the following commands for commit 6d90c11. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
shilman
added
the
patch:yes
shilman
changed the title
configure() throwsconfigure() throws
shilman
approved these changes
Feb 7, 2022
|
Oh, this was just a small bug I found, not the full fix for the problem @shilman |
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Feb 12, 2022
Core: Ensure we show an error when `configure()` throws
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: When user's
configure()threw, we didn't show an error:What I did
Ensure we handle the (old)
CONFIG_ERRORevent in the manager to show the underlying iframe.How to test
Yes, see test.