Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix typo in ArgsTable tooltip #17404

Merged
merged 1 commit into from Feb 4, 2022

Conversation

symmetriq
Copy link
Contributor

@symmetriq symmetriq commented Feb 3, 2022

Issue: The tooltip for collapsing and showing sections in ArgsTable says "Hide [Section Name]" when visible, and "Side [Section Name]" when hidden.

What I did

Changed "Side" to "Show".

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

The tooltip for collapsing and showing sections in ArgsTags says "Hide [Section Name]" when visible, and "Side [Section Name]" when hidden. Fixed.
@nx-cloud
Copy link

nx-cloud bot commented Feb 3, 2022

☁️ Nx Cloud Report

We didn't find any information for the current pull request with the commit 75ce4c1.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@shilman shilman changed the title Fixed typo in SectionRow Addon-docs: Fix typo in ArgsTable tooltip Feb 4, 2022
@shilman shilman added addon: docs block: argstable bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 4, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch @symmetriq -- thanks so much!!

@shilman shilman merged commit 6a1a1fc into storybookjs:next Feb 4, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 12, 2022
shilman added a commit that referenced this pull request Feb 12, 2022
Addon-docs: Fix typo in ArgsTable tooltip
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs block: argstable bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants