Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Pin version of @mdx-js/react to 1.x.x until we are compatible #17395

Merged
merged 1 commit into from Feb 2, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 2, 2022

(cherry picked from commit 6c24eba)

Issue: MDX v2 was released, and we are installing it, but we are not compatible with it

What I did

Fixed the version to 1.x

How to test

Screenshot 2022-02-02 at 12 12 11

(cherry picked from commit 6c24eba)
@nx-cloud
Copy link

nx-cloud bot commented Feb 2, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit dd51226. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@ndelangen ndelangen self-assigned this Feb 2, 2022
@ndelangen ndelangen added addon: docs bug mdx patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 2, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title set version of @mdx-js/react to 1.x.x CLI: Pin version of @mdx-js/react to 1.x.x until we are compatible Feb 2, 2022
@shilman shilman changed the title CLI: Pin version of @mdx-js/react to 1.x.x until we are compatible CLI: Pin version of @mdx-js/react to 1.x.x until we are compatible Feb 2, 2022
@shilman shilman merged commit 0775033 into next Feb 2, 2022
@shilman shilman deleted the fix/mdxv2 branch February 2, 2022 11:33
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 2, 2022
shilman added a commit that referenced this pull request Feb 2, 2022
CLI: Pin version of `@mdx-js/react` to 1.x.x until we are compatible
@bodograumann
Copy link
Contributor

Something is still missing: #17392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug mdx patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants