Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Fix BuilderConfig can be an object #17320

Merged
merged 1 commit into from Jan 24, 2022
Merged

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 24, 2022

In #16219, the builder key in main.js is allowed to be an object (with key name). However, some other code assumes it is a string.

ERR! TypeError: builder.match is not a function
ERR!     at _callee$ (/Users/tom/GitHub/chromatic/node_modules/@storybook/addon-docs/dist/cjs/frameworks/common/preset.js:133:30)
ERR!     at tryCatch (/Users/tom/GitHub/chromatic/node_modules/regenerator-runtime/runtime.js:63:40)
ERR!     at Generator.invoke [as _invoke] (/Users/tom/GitHub/chromatic/node_modules/regenerator-runtime/runtime.js:294:22)
ERR!     at Generator.next (/Users/tom/GitHub/chromatic/node_modules/regenerator-runtime/runtime.js:119:21)
ERR!     at asyncGeneratorStep (/Users/tom/GitHub/chromatic/node_modules/@storybook/addon-docs/dist/cjs/frameworks/common/preset.js:56:103)
ERR!     at _next (/Users/tom/GitHub/chromatic/node_modules/@storybook/addon-docs/dist/cjs/frameworks/common/preset.js:58:194)

What I did

Fixed, actually used types properly.

How to test

Create an app that uses the FS cache. Should we do that in an example @shilman?

@nx-cloud
Copy link

nx-cloud bot commented Jan 24, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 033ace8. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title BuilderConfig can be an object Addon-docs: Fix BuilderConfig can be an object Jan 24, 2022
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@shilman shilman added addon: docs patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jan 24, 2022
@shilman shilman merged commit 9f1bf78 into next Jan 24, 2022
@shilman shilman deleted the fix-builder-config-object branch January 24, 2022 14:45
@shilman shilman removed the patch:yes Bugfix & documentation PR that need to be picked to main branch label Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants