Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: Remove useless unfetch #17306

Merged
merged 1 commit into from Jan 21, 2022
Merged

Core: Remove useless unfetch #17306

merged 1 commit into from Jan 21, 2022

Conversation

7rulnik
Copy link
Contributor

@7rulnik 7rulnik commented Jan 20, 2022

Issue:

What I did

Removed unfetch imports from virtual entrypoint because it not used anywhere

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@nx-cloud
Copy link

nx-cloud bot commented Jan 20, 2022 •
edited

☁️ Nx Cloud Report

CI ran the following commands for commit 0aa04fd. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Remove useless unfetch Core: Remove useless unfetch Jan 21, 2022
@shilman shilman added core maintenance User-facing maintenance tasks labels Jan 21, 2022
shilman
shilman approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙈 Thanks for the fix @7rulnik

@shilman shilman merged commit d6e3ded into storybookjs:next Jan 21, 2022
@7rulnik 7rulnik deleted the remove-useless-unfetch branch January 21, 2022 21:29
@joshwooding joshwooding mentioned this pull request Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@7rulnik @shilman