Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prettier transpile problems #17239

Merged
merged 1 commit into from Jan 14, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 14, 2022

Issue: #16820

What I did

Our IE compatibility transpilation are having problems with prettier versions greater than 2.3.0

This workaround makes sure we use a compatible version of prettier, according to @prashantpalikhe 's comment #16820 (comment)

How to test

CI passes?

@nx-cloud
Copy link

nx-cloud bot commented Jan 14, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 7ff176c. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! The error in CI has nothing to do with the change, it seems to be related to this

@shilman shilman merged commit 54b1cf4 into next Jan 14, 2022
@shilman shilman deleted the 16820-fix-prettier-transpilation branch January 14, 2022 09:53
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Jan 15, 2022
shilman added a commit that referenced this pull request Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants