Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack5: Fix manager.js process references #17213

Merged
merged 1 commit into from Jan 12, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Jan 12, 2022

Issue: #16067

What I did

Add ProvidePlugin for manager (it was already added to preview)

Self-merging @tmeasday

How to test

See repro in issue (tested by hand) by @tylerjlawson

// .storybook/manager.js
console.log({ process });

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core builder-webpack5 labels Jan 12, 2022
@nx-cloud
Copy link

nx-cloud bot commented Jan 12, 2022

☁️ Nx Cloud Report

CI ran the following commands for commit 5d78044. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 79cf4af into next Jan 12, 2022
@shilman shilman deleted the 16067-fix-manager-process branch January 12, 2022 08:38
@shilman shilman mentioned this pull request Jan 12, 2022
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jan 15, 2022
shilman added a commit that referenced this pull request Jan 15, 2022
Webpack5: Fix manager.js process references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug builder-webpack5 core patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant