Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting project args/argTypes for v6 store #17043

Merged
merged 2 commits into from Jan 5, 2022
Merged

Conversation

tmeasday
Copy link
Member

Issue: #11697

What I did

Add addArgs and addArgTypes at the project level in ClientApi.

Allow wiring it through.

How to test

Try adding:

export const argTypes = { color: { control: 'color' } };
export const args = { color: 'red' };
  • Is this testable with Jest or Chromatic screenshots?

We don't have tests for this level of the stack :/

@nx-cloud
Copy link

nx-cloud bot commented Dec 20, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit 0c63303. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman changed the title Allow setting project arg(Type)s for v6 store Allow setting project args/argTypes for v6 store Jan 5, 2022
@shilman shilman merged commit 48763ac into next Jan 5, 2022
@shilman shilman deleted the 11697-project-args-v6 branch January 5, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants