Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source-loader: Fix node.declaration edge case #17027

Merged
merged 1 commit into from Dec 16, 2021

Conversation

mgcrea
Copy link
Contributor

@mgcrea mgcrea commented Dec 16, 2021

Issue: #16984

What I did

Small patch to fix a potential regression introduced in v6.4.9 in some edge cases when parsing the AST.

@nx-cloud
Copy link

nx-cloud bot commented Dec 16, 2021

☁️ Nx Cloud Report

CI ran the following commands for commit fa3a289. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman added bug patch:yes Bugfix & documentation PR that need to be picked to main branch source-loader labels Dec 16, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ideally we would have more tests etc around this, but will probably rewrite the library before that happens and add a bunch of tests then. Thanks for the fix @mgcrea !!! 🙏

@shilman shilman changed the title Fix source-loader node.declaration edge case (closes #16984) Source-loader: Fix node.declaration edge case Dec 16, 2021
@shilman shilman merged commit 8c6427b into storybookjs:next Dec 16, 2021
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 27, 2021
shilman added a commit that referenced this pull request Dec 27, 2021
Source-loader: Fix node.declaration edge case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch source-loader
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants