Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix mainjsFramework automigrate #16866

Merged
merged 1 commit into from Dec 1, 2021

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 1, 2021

Issue: #16864

What I did

Fix missing test for mainjs file

self-merging @yannbf

How to test

Run in a project without a main.js file

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 1, 2021
@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2021

Nx Cloud Report

CI ran the following commands for commit 5a92798. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2021

Nx Cloud Report

We didn't find any information for the current pull request with the commit 5a92798.
You might need to set the 'NX_BRANCH' environment variable in your CI pipeline.

Check the Nx Cloud Github Integration documentation for more information.


Sent with 💌 from NxCloud.

@shilman shilman merged commit af7f940 into next Dec 1, 2021
@shilman shilman deleted the 16864-fix-mainjsframework-automigrate branch December 1, 2021 23:10
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2021
shilman added a commit that referenced this pull request Dec 1, 2021
…automigrate

CLI: Fix mainjsFramework automigrate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant