Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't render with modernInline if inlineStories is false #16853

Merged
merged 2 commits into from Dec 1, 2021

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Dec 1, 2021

Issue: #16768

What I did

Check the inline prop before using the modern inline mode.

How to test

This story: http://localhost:9011/?path=/docs/demo-button-id--with-text from official-storybook

@tmeasday tmeasday requested a review from shilman December 1, 2021 06:07
@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2021

Nx Cloud Report

CI ran the following commands for commit ac5d50b. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

Status Command
#000000 nx run-many --target=prepare --all --parallel --max-parallel=15

Sent with 💌 from NxCloud.

@shilman shilman added addon: docs bug patch:yes Bugfix & documentation PR that need to be picked to main branch labels Dec 1, 2021
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@shilman shilman changed the title Don't render w/ modernInline if inlineStories is false Don't render with modernInline if inlineStories is false Dec 1, 2021
@shilman shilman merged commit 327e259 into next Dec 1, 2021
@shilman shilman deleted the 16768-modernInline-respect-no-inline branch December 1, 2021 06:30
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Dec 1, 2021
shilman added a commit that referenced this pull request Dec 1, 2021
…-no-inline

Don't render with `modernInline` if `inlineStories` is `false`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: docs bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants