Preview: Don't hide the story while preparing #16850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nx Cloud ReportCI ran the following commands for commit 0c79c53. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch
Sent with 💌 from NxCloud. |
shilman
approved these changes
Dec 1, 2021
shilman
added
the
patch:yes
shilman
changed the title
shilman
added
the
patch:done
shilman
added a commit
that referenced
this pull request
Dec 1, 2021
Preview: Don't hide the story while preparing
This was referenced Dec 1, 2021
|
Nothing, just moved it there for consistency with the other css for this file |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #16847, #16798
What I did
Removed the code to hide the story while not "showing" (see this comment).
Note the original code:
Did not apply to anything, so I didn't put it back. There is
.sb-main-padded, etc for the different layouts, but there is nosb-main-xclass for when you have no layout (the default).How to test
sb-show-main, addsb-show-preparing-storyorsb-show-preparing-docsto thebody. Check the story is not visible.examples/vue-kitchen-sink, visit http://localhost:9009/?path=/docs/addon-actions--action-only (for [Storybook 6.4] [Vue] [addon-docs] Stories are hidden in docs tab #16798)